Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greedy ioloop working #1870

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Greedy ioloop working #1870

merged 3 commits into from
Sep 2, 2020

Conversation

vEpiphyte
Copy link
Contributor

  • Re-enable the SYN_GREEDY_CORO flag
  • Set the ioloop into debug mode when this is enabled

This should be considered for use in development/debugging, not for general production use.

@vEpiphyte vEpiphyte added the bug label Sep 2, 2020
@vEpiphyte vEpiphyte added this to the 2.7.2 milestone Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #1870 into master will decrease coverage by 2.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
- Coverage   96.58%   93.73%   -2.86%     
==========================================
  Files         141      141              
  Lines       27626    27629       +3     
==========================================
- Hits        26683    25897     -786     
- Misses        943     1732     +789
Flag Coverage Δ
#linux 93.73% <100.00%> (-2.86%) ⬇️
#linux_replay 66.68% <100.00%> (+7.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/glob.py 100.00% <100.00%> (+2.77%) ⬆️
synapse/lib/crypto/ecc.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/lib/crypto/tinfoil.py 0.00% <0.00%> (-100.00%) ⬇️
synapse/cmds/cron.py 10.37% <0.00%> (-87.17%) ⬇️
synapse/cmds/boss.py 23.72% <0.00%> (-76.28%) ⬇️
synapse/axon.py 74.12% <0.00%> (-25.00%) ⬇️
synapse/lib/dyndeps.py 67.44% <0.00%> (-23.26%) ⬇️
synapse/models/files.py 78.57% <0.00%> (-20.54%) ⬇️
synapse/lib/certdir.py 80.39% <0.00%> (-17.90%) ⬇️
synapse/lib/output.py 80.00% <0.00%> (-16.67%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a021f23...0d8c875. Read the comment docs.

@vEpiphyte vEpiphyte merged commit 05bdf27 into master Sep 2, 2020
@vEpiphyte vEpiphyte deleted the bug_greedycoro_work branch September 2, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invisig0th invisig0th invisig0th approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vEpiphyte @invisig0th